Prepare tests and implementation for adding bootstrapped deb containers implementation#968
Draft
invidian wants to merge 5 commits intoproject-dalec:mainfrom
Draft
Prepare tests and implementation for adding bootstrapped deb containers implementation#968invidian wants to merge 5 commits intoproject-dalec:mainfrom
invidian wants to merge 5 commits intoproject-dalec:mainfrom
Conversation
That should make tests more targetted for their intended scope. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
invidian
force-pushed
the
invidian/refactor-deb-container
branch
from
e728014 to
8bca1cc
Compare
…ainers Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
invidian
force-pushed
the
invidian/refactor-deb-container
branch
from
8bca1cc to
53b3619
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR refactors existing implementation of building deb containers into smaller functions which will be re-used by the upcoming bootstrapped containers implementation.
It also changes some tests to target package instead of container, so we can better confine container-specific tests and make them re-usable across different targets, namely existing deb testing target and upcoming new minimal containers.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Part of #448
Special notes for your reviewer:
I am not sure whether change of targets reduce our test coverage in some way.